Add tests for forge overflow scenarios

2 files changed, 112 insertions, 3 deletions

diff --git a/lv2/atom/forge-overflow-test.c b/lv2/atom/forge-overflow-test.c
new file mode 100644
index 0000000..7a5d102
--- /dev/null
+++ b/lv2/atom/forge-overflow-test.c
@@ -0,0 +1,109 @@
+/*
+  Copyright 2019 David Robillard <http://drobilla.net>
+
+  Permission to use, copy, modify, and/or distribute this software for any
+  purpose with or without fee is hereby granted, provided that the above
+  copyright notice and this permission notice appear in all copies.
+
+  THIS SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+  WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+  MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+  ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+  WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+  ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+  OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+*/
+
+#include "lv2/atom/atom-test-utils.c"
+#include "lv2/atom/atom.h"
+#include "lv2/atom/forge.h"
+#include "lv2/atom/util.h"
+#include "lv2/urid/urid.h"
+
+#include <stdint.h>
+#include <stdlib.h>
+#include <string.h>
+
+static int
+test_string_overflow(void)
+{
+	static const size_t max_chars = 15;
+	static const size_t capacity  = sizeof(LV2_Atom_String) + max_chars + 1;
+	static const char*  str       = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
+
+	uint8_t*       buf = (uint8_t*)malloc(capacity);
+	LV2_URID_Map   map = { NULL, urid_map };
+	LV2_Atom_Forge forge;
+	lv2_atom_forge_init(&forge, &map);
+
+	// Check that writing increasingly long strings fails at the right point
+	for (size_t count = 0; count < max_chars; ++count) {
+		lv2_atom_forge_set_buffer(&forge, buf, capacity);
+
+		const LV2_Atom_Forge_Ref ref =
+		        lv2_atom_forge_string(&forge, str, count);
+		if (!ref) {
+			return test_fail("Failed to write %zu byte string\n", count);
+		}
+	}
+
+	// Failure writing to an exactly full forge
+	LV2_Atom_Forge_Ref ref = 0;
+	if ((ref = lv2_atom_forge_string(&forge, str, max_chars + 1))) {
+		return test_fail("Successfully wrote past end of buffer\n");
+	}
+
+	// Failure writing body after successfully writing header
+	lv2_atom_forge_set_buffer(&forge, buf, sizeof(LV2_Atom) + 1);
+	if ((ref = lv2_atom_forge_string(&forge, "AB", 2))) {
+		return test_fail("Successfully wrote atom header past end\n");
+	}
+
+	free(buf);
+	return 0;
+}
+
+static int
+test_literal_overflow(void)
+{
+	static const size_t capacity = sizeof(LV2_Atom_Literal) + 2;
+
+	uint8_t*           buf = (uint8_t*)malloc(capacity);
+	LV2_URID_Map       map = { NULL, urid_map };
+	LV2_Atom_Forge_Ref ref = 0;
+	LV2_Atom_Forge     forge;
+	lv2_atom_forge_init(&forge, &map);
+
+	// Failure in atom header
+	lv2_atom_forge_set_buffer(&forge, buf, 1);
+	if ((ref = lv2_atom_forge_literal(&forge, "A", 1, 0, 0))) {
+		return test_fail("Successfully wrote atom header past end\n");
+	}
+
+	// Failure in literal header
+	lv2_atom_forge_set_buffer(&forge, buf, sizeof(LV2_Atom) + 1);
+	if ((ref = lv2_atom_forge_literal(&forge, "A", 1, 0, 0))) {
+		return test_fail("Successfully wrote literal header past end\n");
+	}
+
+	// Success (only room for one character + null terminator)
+	lv2_atom_forge_set_buffer(&forge, buf, capacity);
+	if (!(ref = lv2_atom_forge_literal(&forge, "A", 1, 0, 0))) {
+		return test_fail("Failed to write small enough literal\n");
+	}
+
+	// Failure in body
+	lv2_atom_forge_set_buffer(&forge, buf, capacity);
+	if ((ref = lv2_atom_forge_literal(&forge, "AB", 2, 0, 0))) {
+		return test_fail("Successfully wrote literal body past end\n");
+	}
+
+	free(buf);
+	return 0;
+}
+
+int
+main(void)
+{
+	return test_string_overflow() || test_literal_overflow();
+}
diff --git a/wscript b/wscript
index 400e6a2..95ba0c5 100644
--- a/wscript
+++ b/wscript
@@ -214,7 +214,7 @@ def build_spec(bld, path):
     old_include_dir = os.path.join(bld.env.INCLUDEDIR, spec_map[name])
 
     # Build test program if applicable
-    if bld.env.BUILD_TESTS and bld.path.find_node(path + '/%s-test.c' % name):
+    for test in bld.path.ant_glob(os.path.join(path, '*-test.c')):
         test_lib       = []
         test_cflags    = ['']
         test_linkflags = ['']
@@ -225,9 +225,9 @@ def build_spec(bld, path):
 
         # Unit test program
         bld(features     = 'c cprogram',
-            source       = path + '/%s-test.c' % name,
+            source       = test,
             lib          = test_lib,
-            target       = path + '/%s-test' % name,
+            target       = os.path.splitext(str(test.get_bld()))[0],
             install_path = None,
             cflags       = test_cflags,
             linkflags    = test_linkflags)