From 7f3a2651a3635232d94f7bf9ce23d6b575735732 Mon Sep 17 00:00:00 2001
From: David Robillard <d@drobilla.net>
Date: Thu, 7 Jul 2022 18:59:13 -0400
Subject: Remove unnecessary parentheses
Unfortunately, GCC and clang-tidy have conflicting warnings here. Side with
compiler warnings, being generally more relevant than a tool only used by
developers.
---
lv2/atom/util.h | 12 ++++++------
wscript | 1 -
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/lv2/atom/util.h b/lv2/atom/util.h
index f4612e9..16d2c00 100644
--- a/lv2/atom/util.h
+++ b/lv2/atom/util.h
@@ -125,13 +125,13 @@ lv2_atom_sequence_next(const LV2_Atom_Event* i)
@endcode
*/
#define LV2_ATOM_SEQUENCE_FOREACH(seq, iter) \
- for (LV2_Atom_Event * (iter) = lv2_atom_sequence_begin(&(seq)->body); \
+ for (LV2_Atom_Event * iter = lv2_atom_sequence_begin(&(seq)->body); \
!lv2_atom_sequence_is_end(&(seq)->body, (seq)->atom.size, (iter)); \
(iter) = lv2_atom_sequence_next(iter))
/** Like LV2_ATOM_SEQUENCE_FOREACH but for a headerless sequence body. */
#define LV2_ATOM_SEQUENCE_BODY_FOREACH(body, size, iter) \
- for (LV2_Atom_Event * (iter) = lv2_atom_sequence_begin(body); \
+ for (LV2_Atom_Event * iter = lv2_atom_sequence_begin(body); \
!lv2_atom_sequence_is_end(body, size, (iter)); \
(iter) = lv2_atom_sequence_next(iter))
@@ -224,14 +224,14 @@ lv2_atom_tuple_next(const LV2_Atom* i)
@endcode
*/
#define LV2_ATOM_TUPLE_FOREACH(tuple, iter) \
- for (LV2_Atom * (iter) = lv2_atom_tuple_begin(tuple); \
+ for (LV2_Atom * iter = lv2_atom_tuple_begin(tuple); \
!lv2_atom_tuple_is_end( \
LV2_ATOM_BODY(tuple), (tuple)->atom.size, (iter)); \
(iter) = lv2_atom_tuple_next(iter))
/** Like LV2_ATOM_TUPLE_FOREACH but for a headerless tuple body. */
#define LV2_ATOM_TUPLE_BODY_FOREACH(body, size, iter) \
- for (LV2_Atom * (iter) = (LV2_Atom*)(body); \
+ for (LV2_Atom * iter = (LV2_Atom*)(body); \
!lv2_atom_tuple_is_end(body, size, (iter)); \
(iter) = lv2_atom_tuple_next(iter))
@@ -284,13 +284,13 @@ lv2_atom_object_next(const LV2_Atom_Property_Body* i)
@endcode
*/
#define LV2_ATOM_OBJECT_FOREACH(obj, iter) \
- for (LV2_Atom_Property_Body * (iter) = lv2_atom_object_begin(&(obj)->body); \
+ for (LV2_Atom_Property_Body * iter = lv2_atom_object_begin(&(obj)->body); \
!lv2_atom_object_is_end(&(obj)->body, (obj)->atom.size, (iter)); \
(iter) = lv2_atom_object_next(iter))
/** Like LV2_ATOM_OBJECT_FOREACH but for a headerless object body. */
#define LV2_ATOM_OBJECT_BODY_FOREACH(body, size, iter) \
- for (LV2_Atom_Property_Body * (iter) = lv2_atom_object_begin(body); \
+ for (LV2_Atom_Property_Body * iter = lv2_atom_object_begin(body); \
!lv2_atom_object_is_end(body, size, (iter)); \
(iter) = lv2_atom_object_next(iter))
diff --git a/wscript b/wscript
index f855a67..43206ec 100644
--- a/wscript
+++ b/wscript
@@ -123,7 +123,6 @@ def configure(conf):
'-Wno-float-equal',
'-Wno-inline',
'-Wno-padded',
- '-Wno-parentheses',
'-Wno-suggest-attribute=const',
'-Wno-suggest-attribute=malloc',
'-Wno-suggest-attribute=pure',
--
cgit v1.2.1