From 326ecdf238921dc12645f2c31f4882499a387aa0 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Wed, 16 Dec 2020 16:54:00 +0100 Subject: Add assertions for atom buffer sizes This avoids warnings about potential null pointer dereferences, which is true, but in this case the buffer are static so it's really a programming error if there is ever an overrun. --- plugins/eg-sampler.lv2/sampler_ui.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'plugins/eg-sampler.lv2') diff --git a/plugins/eg-sampler.lv2/sampler_ui.c b/plugins/eg-sampler.lv2/sampler_ui.c index 8dddd4c..3070828 100644 --- a/plugins/eg-sampler.lv2/sampler_ui.c +++ b/plugins/eg-sampler.lv2/sampler_ui.c @@ -89,6 +89,8 @@ on_file_set(GtkFileChooserButton* widget, void* handle) LV2_Atom* msg = (LV2_Atom*)write_set_file(&ui->forge, &ui->uris, filename, strlen(filename)); + assert(msg); + ui->write(ui->controller, 0, lv2_atom_total_size(msg), ui->uris.atom_eventTransfer, msg); @@ -310,6 +312,9 @@ instantiate(const LV2UI_Descriptor* descriptor, LV2_Atom_Forge_Frame frame; LV2_Atom* msg = (LV2_Atom*)lv2_atom_forge_object( &ui->forge, &frame, 0, ui->uris.patch_Get); + + assert(msg); + lv2_atom_forge_pop(&ui->forge, &frame); ui->write(ui->controller, 0, lv2_atom_total_size(msg), -- cgit v1.2.1